dax/qmk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix helix/rev2 not working properly when using split_common. (#16512)

Browse Source 
When helix/rev2 was using split_common, it didn't work properly and I couldn't type on the right hand side.

The cause is that the following code, added in 0.16.0 to `quantum/keyboard.c`, does not include `quantum/split_common/split_util.h` but instead includes `keyboards/helix/rev2/split_util.h`. Therefore, `split_pre_init()/split_post_init()` in `quantum/split_common/split_util.c` was not called.

```c
  #ifdef SPLIT_KEYBOARD
  #    include "split_util.h"
  #endif
```
This commit is contained in:
Takeshi ISHII
2022-03-04 05:23:49 +09:00
committed by GitHub
parent ae2c77c827
commit 4a66bdf294
6 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
keyboards/helix/rev2/local_features.mk
View File

@@ -52,9 +52,10 @@ ifneq ($(strip $(SPLIT_KEYBOARD)), yes)
CUSTOM_MATRIX = yes
SRC += rev2/matrix.c
SRC += rev2/split_util.c
SRC += rev2/split_scomm.c
SRC += rev2/custom/matrix.c
SRC += rev2/custom/split_util.c
SRC += rev2/custom/split_scomm.c
KEYBOARD_PATHS += $(HELIX_TOP_DIR)/rev2/custom
endif
########